Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krita: set -Wno-deprecated-copy for gcc #77526

Merged
merged 1 commit into from Jan 11, 2020
Merged

krita: set -Wno-deprecated-copy for gcc #77526

merged 1 commit into from Jan 11, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 11, 2020 •
edited

This reduces the build log length to fix the build on the Hydra.

Motivation for this change

Fixes: #77509

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
krita: set -Wno-deprecated-copy for gcc
66dde82 
This reduces the build log length to fix the build on the Hydra.
@ofborg ofborg bot requested a review from abbradar January 11, 2020 20:33
vcunat
vcunat approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log's down to ~ 7MB for me.

vcunat added a commit that referenced this pull request Jan 11, 2020
@vcunat
Merge #77526: krita: set -Wno-deprecated-copy for gcc
7048b56 
This reduces the build log length to fix the build on the Hydra.
@vcunat vcunat merged commit 66dde82 into NixOS:master Jan 11, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
@vcunat @dtzWill
Merge NixOS#77526: krita: set -Wno-deprecated-copy for gcc
9542d3c 
This reduces the build log length to fix the build on the Hydra.

(cherry picked from commit 7048b56)
@veprbl veprbl deleted the pr/krita_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Krita does not build on hydra because of 'Log limit exceeded'
2 participants
@veprbl @vcunat