Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.XMLTwig: install xml_grep #77558

Merged
merged 1 commit into from Mar 10, 2020
Merged

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 12, 2020

Motivation for this change

Make tools tools that come with XML-Twig available when installing perlPackages.XMLTwig

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raboof the xml_spellcheck tool won't work with this as it references aspell. There may or may not be issues with other tools too, xml_spellcheck was the only one I noticed after briefly looking.

@raboof raboof changed the title perlPackages.XMLTwig: install tools like xml_grep perlPackages.XMLTwig: install xml_grep Feb 29, 2020
@raboof
Copy link
Member Author

raboof commented Feb 29, 2020

the xml_spellcheck tool won't work with this as it references aspell. There may or may not be issues with other tools too, xml_spellcheck was the only one I noticed after briefly looking.

Fair enough, reduced the scope of the PR to just xml_grep, which is the one I was interested in. That one definitely works for me.

@raboof raboof requested a review from aanderse February 29, 2020 16:48
@aanderse
Copy link
Member

No interest in including aspell? If not that is fine, but it should be a simple sed to include it... I'm good either way.

@aanderse aanderse requested a review from volth February 29, 2020 16:50
@raboof
Copy link
Member Author

raboof commented Feb 29, 2020

No interest in including aspell?

I wasn't sure people would like growing the number of run-time dependencies of the package, and since I personally wasn't interested in that one I took the easy way out ;)

@aanderse
Copy link
Member

aanderse commented Feb 29, 2020

@GrahamcOfBorg build perldevelPackages.XMLTwig perlPackages.XMLTwig

@aanderse
Copy link
Member

@raboof sorry I lost track of this. Circling back now... can you look into the failed builds please?

@raboof
Copy link
Member Author

raboof commented Mar 10, 2020

@GrahamcOfBorg build perldevelPackages.XMLTwig perlPackages.XMLTwig

@raboof
Copy link
Member Author

raboof commented Mar 10, 2020

Oh, I missed the failures entirely. They didn't seem familiar, so I just rebased on lastest nixos-unstable - now it seems fine...

@aanderse aanderse merged commit 7836b04 into NixOS:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants