Fix: Use after return for stack allocated object #7926
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetCurrentSong() returns a copy of an object containing a string buffer. A pointer to this buffer can get stored into the global string formatting parameters, in which it can escape the function that called GetCurrentSong(). This means a pointer to an invalid object is stuck in a global variable. Solve it by returning a reference instead, and make a fixed no-song object that a reference to will stay valid.