Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axel: enable darwin #77593

Merged
merged 1 commit into from Jan 13, 2020
Merged

axel: enable darwin #77593

merged 1 commit into from Jan 13, 2020

Conversation

lionello
Copy link
Contributor

Motivation for this change

Wanted axel on MacOS.

Things done

Changed platforms to unix to support building on Darwin.

This was previously changed by @LnL7 in c195e52 to limit to Linux. This derivation appears to work fine on Darwin now.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lionello
Allow building on Darwin
f2ad253 
This derivation appears to work fine on Darwin.
@lionello
Copy link
Contributor Author

@LnL7 do you remember why you had limited this to Linux in c195e52?

jonringer
jonringer reviewed Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should be:

axel: enable darwin

@jonringer jonringer changed the title Allow building on Darwin alex: enable darwin Jan 13, 2020
@jonringer jonringer changed the title alex: enable darwin axel: enable darwin Jan 13, 2020
@jonringer
Copy link
Contributor

@GrahamcOfBorg build axel

@Mic92 Mic92 merged commit c926ef8 into NixOS:master Jan 13, 2020
@Mic92
Copy link
Member

Mic92 commented Jan 13, 2020

Fixed commit title by squashing.

@LnL7
Copy link
Member

LnL7 commented Jan 13, 2020

@lionello Was broken for over a year and couldn't find anything straightforward to fix it https://hydra.nixos.org/job/nixpkgs/trunk/axel.x86_64-darwin/all.

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 29, 2020
@lionello @dtzWill
axel: enable darwin (NixOS#77593)
72ee2bf 
This derivation appears to work fine on Darwin.

(cherry picked from commit c926ef8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lionello @jonringer @Mic92 @LnL7