test-driver.py: Share the shared dir between VMs #77587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the python test driver to match the behavior of the perl test driver. I.e. the directory mounted into /tmp/shared should be the same for all machines. This probably fixes many tests, but I found this while investigating failures in nixos/tests/ceph-multi-node.nix.
|
In fact, it's the |
The docstring says it uses a directory shared among all vms, although that doesn't seem necessary for the functionality. However, it does need to be consistent between the guest and host.
|
I updated |
|
@GrahamcOfBorg build nixosTests.systemd-analyze |
|
For some reason github decides this PR is still open, even though it merged it in. |
pull bot
pushed a commit
to avitex/nixpkgs
that referenced
this pull request
Jan 19, 2020
test-driver.py: Share the shared dir between VMs
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 20, 2020
test-driver.py: Share the shared dir between VMs (cherry picked from commit 764aba4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the python test driver to match the behavior of the perl
test driver. I.e. the directory mounted into /tmp/shared should be the
same for all machines.
This probably fixes many tests, but I found this while investigating
failures in nixos/tests/ceph-multi-node.nix.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)