Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.uchar: don't depend on opaline at runtime #77544

Merged
merged 1 commit into from Jan 13, 2020
Merged

ocamlPackages.uchar: don't depend on opaline at runtime #77544

merged 1 commit into from Jan 13, 2020

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Jan 12, 2020 •
edited

Motivation for this change

Took me a long time to track down why I was having to build 2 OCaml compilers (one for host, one for target) in my project when cross-compiling to musl64 static.

opaline is only needed during the install phase so it shouldn't end up in either build inputs. These additions are in line with how buildDunePackage installs its packages too:

nixpkgs/pkgs/build-support/ocaml/dune.nix

Line 24 in 353ea7f

${opaline}/bin/opaline -prefix $out -libdir $OCAMLFIND_DESTDIR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @vbgl @Zimmi48

@vbgl
Copy link
Contributor

vbgl commented Jan 13, 2020

@GrahamcOfBorg build acgtk eff framac jackline ocaml-crunch ocamlformat satysfi stog trv why3

@vbgl vbgl merged commit 10c8978 into NixOS:master Jan 13, 2020
@anmonteiro anmonteiro deleted the anmonteiro/uchar-opaline branch January 13, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmonteiro @vbgl