Skip to content

fix catAttrs documentation signature #77518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2020
Merged

fix catAttrs documentation signature #77518

merged 1 commit into from
Jan 11, 2020
+1 −1

Conversation

iv-nn
Copy link
Contributor

@iv-nn iv-nn commented Jan 11, 2020

Motivation for this change

catAttrs second argument is a list of attribute sets but it's function signature in the doc was only AttrSet.

Things done

Changed to [AttrSet].

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@iv-nn
fix catAttrs documentation signature

Verified

This commit was signed with the committer’s verified signature.
sikmir Nikolay Korotkiy
GPG key ID: D1DE6D7F693663A5
Verified
Learn about vigilant mode
252eabf
@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 11, 2020
@bjornfor bjornfor merged commit 9605add into NixOS:master Jan 11, 2020
@iv-nn iv-nn deleted the fix-doc-catAttrs-signature branch March 19, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor

Assignees
No one assigned
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iv-nn @bjornfor