Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite-analyzer: Fix to be in sync with sqlite. #77508

Closed
wants to merge 1 commit into from
Closed

sqlite-analyzer: Fix to be in sync with sqlite. #77508

wants to merge 1 commit into from

Conversation

jpathy
Copy link
Contributor

@jpathy jpathy commented Jan 11, 2020

Motivation for this change

Fix assertion failure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Jan 11, 2020
View reviewed changes
pkgs/development/libraries/sqlite/analyzer.nix
@@ -6,11 +6,11 @@ in

stdenv.mkDerivation rec {
pname = "sqlite-analyzer";
version = "3.30.0";
version = "3.30.1";

src = assert version == sqlite.version; fetchurl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to use inherit (sqlite) version src; instead? And adding a comment to the top of sqlite file to make sure the analyzer builds and to passthru.tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqlite src doesn't contain the tcl tool. Maybe we should make sqlite src the full source zip? Then we can make this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpathy Do you want to do it as a followup PR, fixing this assertion failure first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. let's get this merged.

@Luflosi
Copy link
Contributor

Luflosi commented Jun 19, 2020

Since sqlite and sqlite-analyzer are in sync again, this PR can probably be closed again.
What about the discussion above?

@nh2
Copy link
Contributor

nh2 commented Jun 20, 2020

Since sqlite and sqlite-analyzer are in sync again, this PR can probably be closed again.

OK, closing. @jpathy in case you want to do the followup discussed above in #77508 (comment), now might be a good time :)

@nh2 nh2 closed this Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 left review comments

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpathy @Luflosi @nh2 @jtojnar