Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blivet: add missing selinux module #77572

Closed
wants to merge 1 commit into from
Closed

blivet: add missing selinux module #77572

wants to merge 1 commit into from

Conversation

mkg20001
Copy link
Member

Motivation for this change

Currently the hetzner-bootstrap fails with this error

xenon> Traceback (most recent call last):
xenon>   File "/nix/store/0b6bjv4scdn557pac7bmqm6qfhc7smbr-nixpart-0.4.1/bin/.nixpart-wrapped", line 10, in <module>
xenon>     from nixkickstart import NixKickstart
xenon>   File "/nix/store/0b6bjv4scdn557pac7bmqm6qfhc7smbr-nixpart-0.4.1/lib/python2.7/site-packages/nixkickstart.py", line 24, in <module>
xenon>     from blivet.deviceaction import *
xenon>   File "/nix/store/qdd6x15bqjb2ci050djp8a0p3rh8znaf-blivet-0.17-1/lib/python2.7/site-packages/blivet/__init__.py", line 68, in <module>
xenon>     from devices import *
xenon>   File "/nix/store/qdd6x15bqjb2ci050djp8a0p3rh8znaf-blivet-0.17-1/lib/python2.7/site-packages/blivet/devices.py", line 103, in <module>
xenon>     from devicelibs import mdraid
xenon>   File "/nix/store/qdd6x15bqjb2ci050djp8a0p3rh8znaf-blivet-0.17-1/lib/python2.7/site-packages/blivet/devicelibs/mdraid.py", line 25, in <module>
xenon>     from .. import util
xenon>   File "/nix/store/qdd6x15bqjb2ci050djp8a0p3rh8znaf-blivet-0.17-1/lib/python2.7/site-packages/blivet/util.py", line 3, in <module>
xenon>     import selinux
xenon> ImportError: No module named selinux

This should fix it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001 mkg20001 mentioned this pull request Jan 12, 2020
Open
@mkg20001 mkg20001 closed this Jan 12, 2020
@jonringer
Copy link
Contributor

if you're going to revisit this, it would be nice for it to use python3

@mkg20001
Copy link
Member Author

Could the version mismatch be why the module is spuriously missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkg20001 @jonringer