Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update rust example on buildRustPackage #77534

Merged
merged 1 commit into from Jan 12, 2020
Merged

doc: update rust example on buildRustPackage #77534

merged 1 commit into from Jan 12, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jan 11, 2020

The example in the manual was out of date and didn't use the newer pname
convention, which simplifies the fetch call.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
doc: update rust example on buildRustPackage
4f9eb7f 
The example in the manual was out of date and didn't use the newer `pname`
convention, which simplifies the fetch call.
@bhipple
Copy link
Contributor Author

bhipple commented Jan 12, 2020

CC @zimbatm

@zimbatm zimbatm merged commit c2e5ff3 into NixOS:master Jan 12, 2020
@zimbatm
Copy link
Member

zimbatm commented Jan 12, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @zimbatm