Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public-inbox: fix build #77574

Merged
merged 1 commit into from Jan 14, 2020
Merged

public-inbox: fix build #77574

merged 1 commit into from Jan 14, 2020

Conversation

alyssais
Copy link
Member

Motivation for this change

This fixes some two-digit year rounding bugs that started triggering
because 2020 is closer to 2070 than 1970. Apparently two digits years
are still a thing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from teto January 13, 2020 02:02
@alyssais alyssais mentioned this pull request Jan 13, 2020
Closed
10 tasks
@alyssais
public-inbox: fix build
542f6af 
This fixes some two-digit year rounding bugs that started triggering
because 2020 is closer to 2070 than 1970.  Apparently two digits years
are still a thing.
@alyssais alyssais merged commit 10b1ba0 into NixOS:master Jan 14, 2020
@alyssais alyssais deleted the public-inbox-date branch January 14, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alyssais