Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mako: 1.4 -> 1.4.1 #77562

Merged
merged 2 commits into from Jan 12, 2020
Merged

mako: 1.4 -> 1.4.1 #77562

merged 2 commits into from Jan 12, 2020

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Jan 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dywedir
Copy link
Member

dywedir commented Jan 12, 2020

Thanks!

@dywedir dywedir merged commit 484014d into NixOS:master Jan 12, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
mako: 1.4 -> 1.4.1
(cherry picked from commit 484014d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants