Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rx: 0.3.0 -> 0.3.1 #77511

Merged
merged 1 commit into from Jan 11, 2020
Merged

rx: 0.3.0 -> 0.3.1 #77511

merged 1 commit into from Jan 11, 2020

Conversation

minijackson
Copy link
Member

Motivation for this change

Changes: cloudhead/rx@v0.3.0...v0.3.1

Renderer switched from Vulkan to OpenGL, but I'm not sure why.

Not sure if the runtime dependency to libGL should be extended to MacOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @filalex77

@Br1ght0ne
Copy link
Member

@GrahamcOfBorg build rx

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
launches fine

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77511
1 package built:
rx

@jonringer jonringer merged commit df7ed43 into NixOS:master Jan 11, 2020
@minijackson minijackson deleted the rx-0.3.1 branch January 12, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants