Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustPlatform.buildRustPackage: cleaner output on verifyCargoDeps #77567

Merged
merged 1 commit into from Jan 12, 2020
Merged

rustPlatform.buildRustPackage: cleaner output on verifyCargoDeps #77567

merged 1 commit into from Jan 12, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jan 12, 2020

When this fails, the user may want to copy-paste the path to the "bad"
Cargo.lock file to inspect. The trailing . on $cargoDeps. gets caught in
most terminal copy-pastes. Since half the lines already don't have it, this
removes it from all of them for consistent output.

CC @zimbatm

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
rustPlatform.buildRustPackage: cleaner output on verifyCargoDeps
dcbd09d 
When this fails, the user may want to copy-paste the path to the "bad"
Cargo.lock file to inspect. The trailing `.` on `$cargoDeps.` gets caught in
most terminal copy-pastes. Since half the lines already don't have it, this
removes it from all of them for consistent output.
@bhipple bhipple requested a review from andir as a code owner January 12, 2020 16:31
@zimbatm
Copy link
Member

zimbatm commented Jan 12, 2020

good idea

@zimbatm zimbatm merged commit 6e8c377 into NixOS:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @zimbatm