New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packagekit: 1.1.12 -> 1.1.13 #77498
packagekit: 1.1.12 -> 1.1.13 #77498
Conversation
@GrahamcOfBorg test packagekit |
I should probably add myself as a maintainer to this, I can at least receive pings on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
says:
[14 built, 741 copied (2556.1 MiB), 505.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77498
8 package built:
discover gnome3.gnome-packagekit gnome3.gnome-software simple-scan packagekit packagekit-qt pantheon.appcenter system-config-printer
This looks interesting from the changelog
I believe that is this commit PackageKit/PackageKit@d9fe720.
I notice in the build output with this PR there's a system unit installed but no user services.
|
Ooh they just switched to meson ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #77498 (comment).
While visiting: * drop trailing slash in system unit dir * prefer placeholder over escaping
✨ (for folks following along, FYI this was done after the release of this version, so meson is for "next time" 😸 )
Eep, good catch. Thanks!
This doesn't appear to be the case, as nothing is installed when setting the directory somewhere it can write (as suggested below and in most recent commit).
Pushed commit doing this!
Maybe submit an upstream PR? friendly nudge (assuming that seems like a good idea, couldn't say) Wasn't sure if we should point it to |
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
@GrahamcOfBorg test packagekit |
@worldofpeace Is green, good to go or more to do? |
I believe so, though the changelog was slightly confusing. |
Motivation for this change
https://github.com/hughsie/PackageKit/blob/PACKAGEKIT_1_1_13/NEWS
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)