ocrmypdf: 9.2.0 -> 9.5.0 #77494
Merged
ocrmypdf: 9.2.0 -> 9.5.0 #77494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get this error. :( |
flokli
requested changes
Jan 11, 2020
jonringer
requested changes
Jan 11, 2020
There was a problem hiding this comment.
fails to execute:
$ ./results/ocrmypdf/bin/ocrmypdf --help
Traceback (most recent call last):
File "/nix/store/vgdm35qmpnhq9pnm1lny59vrc5v8rzkp-ocrmypdf-9.4.0/bin/.ocrmypdf-wrapped", line 6, in <module>
from ocrmypdf.__main__ import run
File "/nix/store/vgdm35qmpnhq9pnm1lny59vrc5v8rzkp-ocrmypdf-9.4.0/lib/python3.7/site-packages/ocrmypdf/__init__.py", line 18, in <module>
from . import helpers, hocrtransform, leptonica, pdfa, pdfinfo
File "/nix/store/vgdm35qmpnhq9pnm1lny59vrc5v8rzkp-ocrmypdf-9.4.0/lib/python3.7/site-packages/ocrmypdf/leptonica.py", line 67, in <module>
"""
ocrmypdf.exceptions.MissingDependencyError:
---------------------------------------------------------------------
This error normally occurs when ocrmypdf can't find the Leptonica
library, which is usually installed with Tesseract OCR. It could be that
Tesseract is not installed properly, we can't find the installation
on your system PATH environment variable.
The library we are looking for is usually called:
liblept-5.dll (Windows)
liblept*.dylib (macOS)
liblept*.so (Linux/BSD)
Please review our installation procedures to find a solution:
https://ocrmypdf.readthedocs.io/en/latest/installation.html
---------------------------------------------------------------------
EDIT: should have looked at other reviews xD
|
Thanks, apologies for not checking this myself :(. Looking into it a bit, I'm not sure anything is broken/changed other than this error previously was only shown on Windows but now is shown elsewhere: ocrmypdf/OCRmyPDF@5b6ab1e (particularly: ocrmypdf/OCRmyPDF@5b6ab1e#diff-fa4c947e8b0794e9629141a00a65ec9dR50). I'm not sure if this means we never had leptonica working, or if the check is misleading/broken (at least on NixOS, as packaged currently). Unsure how to test this. It seems to find it during the build, as it generates the cffi module for it? |
|
Oh, we already patch in the correct path-- but it's after the check :). Fix coming! |
flokli
requested changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://ocrmypdf.readthedocs.io/en/latest/release_notes.html#v9-4-0
https://ocrmypdf.readthedocs.io/en/latest/release_notes.html#v9-3-0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)