Skip to content

thunderbird, thunderbird-bin: 68.3.1 -> 68.4.1 [Critical security fixes] #77499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2020
Merged

thunderbird, thunderbird-bin: 68.3.1 -> 68.4.1 [Critical security fixes] #77499

merged 2 commits into from
Jan 11, 2020
+247 −247

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 11, 2020

Motivation for this change
  • Critical security fixes
  • Other fixes and improvements

https://www.thunderbird.net/en-US/thunderbird/68.4.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-04/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested only thunderbird-bin. Building thunderbird.

Sorry, something went wrong.

@ofborg ofborg bot requested review from lovesegfault, nbp and edolstra January 11, 2020 07:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 11, 2020
@vcunat vcunat added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 11, 2020
vcunat
vcunat approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used both for a while, without any issues.

vcunat added a commit that referenced this pull request Jan 11, 2020
@vcunat
Merge #77499: thunderbird*: 68.3.1 -> 68.4.1 (security)
a1d4878 
https://www.thunderbird.net/en-US/thunderbird/68.4.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-04/
@vcunat vcunat merged commit f7c1c22 into NixOS:master Jan 11, 2020
vcunat added a commit that referenced this pull request Jan 11, 2020
@vcunat
Merge #77499: thunderbird*: 68.3.0 -> 68.4.1 (security)
0e7a9f7 
https://www.thunderbird.net/en-US/thunderbird/68.4.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-04/

(cherry picked from commit a1d4878)
Re-tested both briefly on 19.09
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

@lovesegfault lovesegfault

@nbp nbp

@edolstra edolstra

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @vcunat @lovesegfault