Fix: default-values are set by "action.yml", and inputs are always strings #3

TrueBrain · 2020-01-12T11:43:36Z

Before this commit, it always checked out tags and submodules,
while the request might have been to not do that.

…rings Before this commit, it always checked out tags and submodules, while the request might have been to not do that.

This way, you have to be explicit what you want "checkout" to do, making for more readable workflows.

For reference, see: https://github.com/actions/checkout/blob/master/src/input-helper.ts

TrueBrain added 3 commits January 12, 2020 12:42

Fix: default-values are set by "action.yml", and inputs are always st…

1d34814

…rings Before this commit, it always checked out tags and submodules, while the request might have been to not do that.

Change: switch default of "with-submodule" in "checkout" to false

23709c2

This way, you have to be explicit what you want "checkout" to do, making for more readable workflows.

Fix: use the same method of boolean inputs as actions/checkout

d881fa4

For reference, see: https://github.com/actions/checkout/blob/master/src/input-helper.ts

TrueBrain force-pushed the fix_checkout branch from 3f931a4 to d881fa4 Compare January 12, 2020 11:52

TrueBrain merged commit 5d59de8 into OpenTTD:master Jan 12, 2020

TrueBrain deleted the fix_checkout branch January 12, 2020 11:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: default-values are set by "action.yml", and inputs are always strings #3

Fix: default-values are set by "action.yml", and inputs are always strings #3

TrueBrain commented Jan 12, 2020

Fix: default-values are set by "action.yml", and inputs are always strings #3

Fix: default-values are set by "action.yml", and inputs are always strings #3

Conversation

TrueBrain commented Jan 12, 2020