Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hakuneko: 1.4.2 -> 5.0.8 #77552

Merged
merged 2 commits into from Jan 13, 2020
Merged

hakuneko: 1.4.2 -> 5.0.8 #77552

merged 2 commits into from Jan 13, 2020

Conversation

nloomans
Copy link
Contributor

Motivation for this change

HakuNeko switched to electron. Since this is the latest release the broken status can be dropped. The original maintainer (@RubenAstudillo) dropped support for the package so I decided to pick it up.

I based this on the simplenote package, and implemented the setuid fix from the slack package.

This is my first contribution to nixpkgs! So all nitpicks are welcome!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jan 12, 2020

tested with nix-review. Works well but on startup, the program display its usage/help on stdout which I found odd.
Related issue #45332
Thank you very much for the PR.

@nloomans
hakuneko: 1.4.2 -> 5.0.8
c095386 
HakuNeko switched to electron. Since this is the latest release the
broken status can be dropped. The original maintainer (Ruben Astudillo)
dropped support for the package so I decided to pick it up.

I based this on the simplenote package, and implemented the setuid fix
from the slack package.

Closes NixOS#45332
@nloomans
Copy link
Contributor Author

@teto Thanks for the feedback! I resolved your issues and added i686-linux support because upstream supports it. I couldn't directly test it but it will likely work and ofborg should detect it if there are any errors in the derivation itself.

@teto
Copy link
Member

teto commented Jan 13, 2020

@GrahamcOfBorg build hakuneko

@teto teto merged commit 60d72d1 into NixOS:master Jan 13, 2020
@teto
Copy link
Member

teto commented Jan 13, 2020

thank you

@nloomans nloomans deleted the hakuneko branch January 13, 2020 20:07
@RubenAstudillo
Copy link
Contributor

Thank you for picking this up. I am an old guard that never took time to learn how to package electron based apps. I will use hakuneko v5 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nloomans @teto @RubenAstudillo @Janik-Haag