Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piper: 0.2.903 -> 0.2.905 [19.09] #77551

Merged
merged 1 commit into from
Jan 14, 2020
Merged

piper: 0.2.903 -> 0.2.905 [19.09] #77551

merged 1 commit into from
Jan 14, 2020
+2 −2

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 12, 2020 •
edited
Loading

Piper is a frontend for libratbag and their versions need to be kept
in sync for piper to work.

Fixes #76695

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @mvnetbiz @pbogdan

Sorry, something went wrong.

@mweinelt
piper: 0.2.903 -> 0.2.905

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
GPG key ID: BD4AA0528F63F17E
Expired
Verified
Learn about vigilant mode
a13b610 
Piper is a frontend for libratbag and their versions need to be kept
in sync for piper to work.

Fixes NixOS#76695
@ofborg ofborg bot requested a review from mvnetbiz January 12, 2020 12:06
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 12, 2020
@c0bw3b c0bw3b merged commit 644045d into NixOS:release-19.09 Jan 14, 2020
@c0bw3b c0bw3b mentioned this pull request Jan 14, 2020
Closed
@mweinelt mweinelt deleted the piper-19.09 branch January 14, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbogdan pbogdan

@c0bw3b c0bw3b

@mvnetbiz mvnetbiz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @pbogdan @c0bw3b