Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibus-engines.table-others: 1.3.9 -> 1.3.11 #77517

Merged
merged 1 commit into from Jan 18, 2020
Merged

ibus-engines.table-others: 1.3.9 -> 1.3.11 #77517

merged 1 commit into from Jan 18, 2020

Conversation

McSinyx
Copy link
Member

@McSinyx McSinyx commented Jan 11, 2020

Motivation for this change

Update ibus-table-others to version 1.3.11 with the following changes:

  • Add Vietnamese input methods Telex and VNI
  • Extend russian translit for latin slavic layouts
  • latex: add most of Unicode 9.0 block Mathematical Alphanumeric Symbols
  • mathwriter-ibus: add superscript alphabets
  • mathwriter-ibus: added Blackboard bold letters
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from laMudri January 11, 2020 15:32
@laMudri
Copy link
Contributor

laMudri commented Jan 11, 2020

Just a version bump; should be fine. I'm not sure how much I need to do as a reviewer. It'd be nice to know if you've tested one of the new/modified input methods on your machine.

@McSinyx
Copy link
Member Author

McSinyx commented Jan 12, 2020

I'm currently using a Vietnamese table and it's working as expected.

@nh2 nh2 merged commit 5cda709 into NixOS:master Jan 18, 2020
@McSinyx McSinyx deleted the ibus-table-others-1-3-11 branch January 18, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laMudri laMudri Awaiting requested review from laMudri

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@McSinyx @laMudri @nh2