Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cawbird: 1.0.3.1 -> 1.0.4 #77583

Merged
merged 1 commit into from Jan 13, 2020
Merged

cawbird: 1.0.3.1 -> 1.0.4 #77583

merged 1 commit into from Jan 13, 2020

Conversation

schmittlauch
Copy link
Member

fixes a crash caused by invalid Twitter API data. That's why it also needs to be backported to release-19.09.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
cawbird: 1.0.3.1 -> 1.0.4
e86c767 
fixes a crash caused by invalid Twitter API data
@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build cawbird

@ofborg ofborg bot requested a review from jonafato January 12, 2020 23:11
jonringer
jonringer approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[3 built, 7 copied (94.0 MiB), 20.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77583
1 package built:
cawbird

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 13, 2020
@jonringer jonringer merged commit 04172da into NixOS:master Jan 13, 2020
@jonringer
Copy link
Contributor

@schmittlauch if you want to cherry-pick this onto the 19.09 branch, and make a PR, it will be much appreciated :)

@schmittlauch schmittlauch mentioned this pull request Jan 13, 2020
Merged
10 tasks
@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmittlauch @jonringer