Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability? Can we warn if a Statement is never assigned to a domain? #303

Closed
RobertBaruch opened this issue Jan 12, 2020 · 2 comments
Closed

Usability? Can we warn if a Statement is never assigned to a domain? #303

RobertBaruch opened this issue Jan 12, 2020 · 2 comments
Labels
improvement
Milestone
0.2

Comments

@RobertBaruch
Copy link

All too often I've been charging ahead writing formal assertions, and I forget to put one in a domain, writing:

Assert(...)

instead of

m.d.comb += Assert(...)

This sort of thing is silently ignored, so I go on merrily believing my formal verification worked, when in fact I simply never verified certain assertions.

If anything, this is especially nasty for Asserts, Assumes, and Covers that do not get added to a domain. Can there at least be a warning there? Is it possible?
@whitequark
Copy link
Contributor

Absolutely possible, and we should do this. We already do this for Elaboratables.

@whitequark whitequark added this to the 0.2 milestone Jan 16, 2020
Closed
@whitequark
Copy link
Contributor

whitequark commented Feb 1, 2020 •
edited by sbourdeauducq

Fixed in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@whitequark @RobertBaruch