Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirtd: fix path to ebtables #77582

Merged
merged 1 commit into from Jan 13, 2020
Merged

libvirtd: fix path to ebtables #77582

merged 1 commit into from Jan 13, 2020

Conversation

andir
Copy link
Member

@andir andir commented Jan 12, 2020

Motivation for this change

With the bump of iptables (#75026) ebtables was renamed from ebtables
to ebtables-legacy. libvirtd requires this binary to be availabe to
configure the host networking.

fixes #75878

cc people involved in the bump/the issue: @dtzWill @TimKlampe @izuk @rembo10 @andersk @kamidon @d4g @costrouc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
libvirtd: fix path to ebtables
22388a5 
With the bump of iptables (NixOS#75026) ebtables was renamed from `ebtables`
to `ebtables-legacy`. libvirtd requires this binary to be availabe to
configure the host networking.

fixes NixOS#75878
@ofborg ofborg bot requested review from globin and fpletz January 12, 2020 22:51
andersk
andersk approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@andersk andersk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@fpletz fpletz merged commit 5f01d21 into NixOS:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersk andersk andersk approved these changes

@fpletz fpletz fpletz approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libvirt: Failed to initialize a valid firewall backend
3 participants
@andir @andersk @fpletz