pkgsStatic: make OpenSSL 1.1 compile #77542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh2
requested changes
Jan 12, 2020
pkgs/top-level/static.nix
Outdated
| openssl = (super.openssl_1_1.override { static = true; }).overrideAttrs (o: { | ||
| configureFlags = (removeUnknownConfigureFlags o.configureFlags) ++ [ | ||
| "no-shared" | ||
| ]; |
There was a problem hiding this comment.
Please explain the rationale of the above with comments, otherwise others will just find unexplained magic incantations :)
There was a problem hiding this comment.
makes sense, done in a new commit!
FRidh
reviewed
Jan 12, 2020
pkgs/top-level/static.nix
Outdated
| # See https://wiki.openssl.org/index.php/Compilation_and_Installation#Configure_Options | ||
| # for a comprehensive list. | ||
| configureFlags = (removeUnknownConfigureFlags o.configureFlags) ++ [ | ||
| "no-shared" |
There was a problem hiding this comment.
could we move this into the openssl expression and add it in case static == true
There was a problem hiding this comment.
Hey @FRidh, thanks for your review. That does make sense, as with all the other derivations.
I (obviously) missed that when porting over from my own overlay. Just pushed a new commit that moves the static configuration to the openssl derivation.
|
@FRidh friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've been using this in my own overlays and it's working well for me. Opening a PR to get feedback and to have it built by CI in case I'm overlooking something.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)