New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of a few actions #1
Conversation
Now always a - over _ or camelCase.
Although this is twice as big as the minimized version, the 'git diff' (and with that the repository space) is significant smaller, expecially over time. It also makes reviews a bit less annoying, as otherwise there is this huge blob of nobody-knows in between there.
Also, make sure the result is trimmed
In other words, things were dry-runs when they shouldn't, and the other way around.
This is a new approach, which is still a bit thin. But this is the best we could come up with for now.
This means that the format parameter did the wrong lookup.
Where 'cut' is 1-indexed, 'split()' is 0-indexed. So off-by-one error.
Can't |
Currently my goal is to first get it to work; after that I hope others join in to make it better :D |
It not only contains the absolute path of the machine that builds, it is also never used. And while doing 'ncc', it becomes part of the 'dist' files, creating diffs that are pointless. Hopefully this resolves that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current stuff is a good start, it can be improved later.
Otherwise this is tested and as far as I can tell in working order.