Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.seahorse: 3.34 -> 3.34.1 #77543

Merged
merged 1 commit into from Jan 12, 2020
Merged

gnome3.seahorse: 3.34 -> 3.34.1 #77543

merged 1 commit into from Jan 12, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 12, 2020
@hedning
Copy link
Contributor

hedning commented Jan 12, 2020

Builds and runs without problems. News seahorse 3.34.1:

  • Fix crash when deleting a subkey [!100]
  • Fix a deadlock when using tofu trust model [!97]
  • Updated translations

@hedning hedning merged commit a9d3d63 into NixOS:master Jan 12, 2020
@zowoq zowoq deleted the seahorse branch January 12, 2020 11:38
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
@zowoq @dtzWill
gnome3.seahorse: 3.34 -> 3.34.1 (NixOS#77543)
7e4af76 
https://gitlab.gnome.org/GNOME/seahorse/blob/3.34.1/NEWS
(cherry picked from commit a9d3d63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @hedning