Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] kernel: set POWERCAP and INTEL_RAPL #77531

Merged
merged 1 commit into from Jan 12, 2020

Conversation

mweinelt
Copy link
Member

These enable some power management settings. They are needed for s-tui
to show power readings
.

The values chosen here match what Arch Linux has. In particular
the Intel specific code is loadable as a module rather than compiled in.

(cherry picked from commit 299e6f0)

Motivation for this change

Backport of #67268. I've been running with this patchset on 19.09 for months.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @andir

These enable some power management settings. They are needed for [s-tui
to show power readings](amanusk/s-tui#105).

The values chosen here match what Arch Linux has. In particular
the Intel specific code is loadable as a module rather than compiled in.

(cherry picked from commit 299e6f0)
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andir andir self-assigned this Jan 11, 2020
@mweinelt mweinelt changed the title kernel: set POWERCAP and INTEL_RAPL [19.09] kernel: set POWERCAP and INTEL_RAPL Jan 11, 2020
@andir
Copy link
Member

andir commented Jan 12, 2020

Did a local test build of both the lts and latest kernel. Tests succeed. I do not see a reason why any of the modules would fail now.

@andir andir merged commit 5dc4d07 into NixOS:release-19.09 Jan 12, 2020
@mweinelt mweinelt deleted the powercap-19.09 branch June 22, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants