Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mynewt-newt: 1.3.0 -> 1.7.0, use buildGoModule #77516

Merged
merged 2 commits into from Feb 1, 2020
Merged

mynewt-newt: 1.3.0 -> 1.7.0, use buildGoModule #77516

merged 2 commits into from Feb 1, 2020

Conversation

Thra11
Copy link
Member

@Thra11 Thra11 commented Jan 11, 2020

Motivation for this change

Update mynewt-newt to 1.7.0. Switch from legacy buildGoPackage to buildGoModule

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and pjones January 11, 2020 14:21
@Thra11
Copy link
Member Author

Thra11 commented Jan 11, 2020

Looks like 1.7.0 has a bug which prevents newt upgrade working with mcuboot (Unreleased workaround/fix is here apache/mynewt-newt@7d4ef3f). Not sure if we should patch it or just wait for a release...

@kalbasit
Copy link
Member

@Thra11 Does 1.7.0 work well with the patch applied? It's probably ok to update it with the patch if it works well.

@Thra11
Copy link
Member Author

Thra11 commented Jan 12, 2020 •
edited

I had to cherry pick an additional commit for the fix to apply cleanly. Having done that, it builds and seems to work. I tried

  1. Removing my existing mynewt installation
  2. Switching to the 1.3.0 version of the package and running newt install
  3. Switching to the patched 1.7.0 version of the package and running newt upgrade
    It seems to have worked ok, where the unpatched version failed.

@ofborg ofborg bot requested a review from kalbasit January 31, 2020 18:08
@kalbasit
Copy link
Member

kalbasit commented Feb 1, 2020

@GrahamcOfBorg build mynewt-newt

@kalbasit kalbasit merged commit 05d62c1 into NixOS:master Feb 1, 2020
@Thra11 Thra11 deleted the mynewt-newt branch February 1, 2020 19:55
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@kalbasit @anna328p
Merge pull request NixOS#77516 from Thra11/mynewt-newt
05cfd49 
mynewt-newt: 1.3.0 -> 1.7.0, use buildGoModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam requested changes

@kalbasit kalbasit kalbasit approved these changes

@pjones pjones Awaiting requested review from pjones

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Thra11 @kalbasit @marsam