Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2c57f19d8981
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ffd6e808b0b7
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Jan 12, 2020

  1. Add the word "template".

    pleroy committed Jan 12, 2020
    Copy the full SHA
    475f6ae View commit details
  2. Copy the full SHA
    3a5d598 View commit details
  3. Merge pull request #2440 from pleroy/Clang

    Add the word "template" in a few places
    pleroy authored Jan 12, 2020
    Copy the full SHA
    ffd6e80 View commit details
Showing with 2 additions and 1 deletion.
  1. +2 −1 geometry/permutation_test.cpp
3 changes: 2 additions & 1 deletion geometry/permutation_test.cpp
Original file line number Diff line number Diff line change
@@ -209,7 +209,8 @@ TEST_F(PermutationTest, Compose) {
for (auto const& right : rhs) {
auto const composition = left * right;
auto const composition_as_orthogonal_maps =
left.Forget<OrthogonalMap>() * right.Forget<OrthogonalMap>();
left.template Forget<OrthogonalMap>() *
right.template Forget<OrthogonalMap>();
for (Length l = 1 * Metre; l < 4 * Metre; l += 1 * Metre) {
// TODO(egg): In C++20 we could have template parameters on the lambda
// which would allow us to deduce this type, instead of having to pass