Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shfmt: 2.6.4 -> 3.0.1 #77537

Merged
merged 1 commit into from
Jan 12, 2020
Merged

shfmt: 2.6.4 -> 3.0.1 #77537

merged 1 commit into from
Jan 12, 2020
+7 −7

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from kalbasit January 11, 2020 23:48
tomberek
tomberek approved these changes Jan 12, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on NixOS. Functions as expected.

@kalbasit kalbasit merged commit e567214 into NixOS:master Jan 12, 2020
@zowoq zowoq deleted the shfmt branch January 12, 2020 07:42
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
@zowoq @dtzWill
shfmt: 2.6.4 -> 3.0.1 (NixOS#77537)
550c7b1 
(cherry picked from commit e567214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit

@tomberek tomberek

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @kalbasit @tomberek