Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsyslog: include libmaxminddb #77300

Merged
merged 2 commits into from Jan 24, 2020
Merged

rsyslog: include libmaxminddb #77300

merged 2 commits into from Jan 24, 2020

Conversation

basilgood
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member

aanderse commented Jan 9, 2020

@basilgood you should add libmaxminddb to buildInputs.

@NeQuissimus NeQuissimus removed their request for review January 9, 2020 14:13
@aanderse
Copy link
Member

@basilgood I was hoping someone who has done some work on this package before would review but that doesn't seem to be the case. I've looked into the docs in a bit more detail and gone through the package in nixpkgs some more so I guess we're good to go, right after you update the declaration of rsyslog-light in all-packages.nix.

Thanks!

@megheaiulian
Copy link
Contributor

@aanderse Please have a look again.

@aanderse
Copy link
Member

Thanks @megheaiulian and @basilgood. I don't use any libmaxminddb stuff with rsyslog so I'm not really in a position to test this. It is a pretty simple change and after reading through the documentation I'm inclined to think I can just click merge, but I'd like to at least hear one person say they've tested this and it works as expected. Have either of you tested this? Anyone?

@megheaiulian
Copy link
Contributor

We're currently running this change on a server where rsyslog adds geoip info to logs.

@aanderse aanderse merged commit ddbb15d into NixOS:master Jan 24, 2020
@megheaiulian megheaiulian deleted the rsyslog branch January 24, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basilgood @aanderse @megheaiulian