Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 79.0.3945.88 -> 79.0.3945.117 #77299

Merged
merged 1 commit into from Jan 25, 2020
Merged

chromium: 79.0.3945.88 -> 79.0.3945.117 #77299

merged 1 commit into from Jan 25, 2020

Conversation

ivan
Copy link
Member

@ivan ivan commented Jan 8, 2020

Motivation for this change

https://chromereleases.googleblog.com/2020/01/stable-channel-update-for-desktop.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

chromium works fine on x86_64 but I haven't tested the other 5 things, please test.

Notify maintainers

cc @bendlas @thefloweringash

@thefloweringash
Copy link
Member

I've successfully tested chromium on aarch64

@thefloweringash
Copy link
Member

thefloweringash commented Jan 9, 2020 •
edited

chromiumBeta is also fine on aarch64. chromiumDev builds but I have yet to make it start. I don't think it's necessary to fix chromiumDev before merging, so LGTM.

@mebubo mebubo mentioned this pull request Jan 19, 2020
Closed
10 tasks
@flokli
Copy link
Contributor

flokli commented Jan 19, 2020

@thefloweringash what do you mean by "I have yet to make it start"?

It built, but fails to start? You didn't try starting it so far?

How's the situation currently on master?

@thefloweringash
Copy link
Member

@thefloweringash what do you mean by "I have yet to make it start"?

It built, but fails to start? You didn't try starting it so far?

It builds, it prints an error on startup relating to having no crashpad_handler, and then it hangs. I also just realized I made a critical typo in the above (now edited): chromiumDev is the affected version.

How's the situation currently on master?

It's apparently uncached. I've started a build but they take a few hours each. I'll report back when I have tested.

@thefloweringash
Copy link
Member

thefloweringash commented Jan 22, 2020 •
edited by primeos

How's the situation currently on master?

chromium and chromiumBeta both refer to version 79. chromiumDev refers to version 80. Testing on aarch64: all of them work (briefly tested by loading a few pages).

I don't think we should delay the upgrade to chromium for the sole case of aarch64+chromiumDev.

@ivan

chromium works fine on x86_64 but I haven't tested the other 5 things, please test.

Just to eliminate ambiguity, what are the 5 other things that need testing here?

From reading this thread, I think the status of this PR is:

platform attribute status tester
x86_64 chromium ✅ @ivan
x86_64 chromiumBeta ? ?
x86_64 chromiumDev ? ?
x86_64 google-chrome ✅ @primeos
x86_64 google-chrome-beta ✅ @primeos
x86_64 google-chrome-dev ❌ @primeos
aarch64 chromium ✅ @thefloweringash
aarch64 chromiumBeta ✅ @thefloweringash
aarch64 chromiumDev ❌ @thefloweringash

@ivan
Copy link
Member Author

ivan commented Jan 22, 2020

Oh, the six things I was thinking of were

chromium
chromiumBeta
chromiumDev
google-chrome
google-chrome-beta
google-chrome-dev

but I guess we have 9 things with the inclusion of the aarch64 chromium builds.

Please take over this PR (i.e. make a new one) if changes are needed, I removed myself from maintainers.

One thing I have sometimes done is hold back a chromiumDev upgrade by removing the version bump for just that channel in upstream-info.nix, but I do not know if that is appropriate here.

primeos
primeos approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atm I don't have the resources to test this, but since it's already tested twice I'm +1 for merging this ASAP (and the diff obviously looks fine as well).

Please take over this PR (i.e. make a new one) if changes are needed, I removed myself from maintainers.

@ivan just to be sure: That means you won't maintain Chromium anymore (which is of course totally fine) and we need a new maintainer (which is the important part)?

In any case: Thank you for maintaining Chromium up util now ❤️.
I often saw your PRs and appreciate your work - thank you :)

@ivan
Copy link
Member Author

ivan commented Jan 24, 2020

@primeos right, I do not plan to make chromium PRs, as I removed my desktop Linuxes for now. Yes, I believe chromium could use another maintainer/tester on x86_64.

If you would like to track upstream's releases, I recommend following the feed on https://chromereleases.googleblog.com/ and filtering for "Stable Channel Update for Desktop". Typically, within a few hours of an upstream release being available, a source tarball is also available and pkgs/applications/networking/browsers/chromium/update.sh can be used to update upstream-info.nix. Note that when upstream does not have a tarball yet, update.sh may silently fail to update a hash in upstream-info.nix, making it look like the version was updated while retaining the old hash.

In upcoming releases, I expect WebGL to break again because of a libGLESv2.so loading issue that this patch is working around, watch out for that.

@primeos
Copy link
Member

primeos commented Jan 25, 2020 •
edited

Gave Google Chrome a quick test in a VM and updated #77299 (comment).

LGTM, IMO google-chrome-dev and chromiumDev shall not delay these updates so I'm going to merge this PR.
If this bugs anyone: Please complain, additional testers for future updates are welcome ;) :P

@ivan: Thank you very much for your response and additional details ❤️.

@primeos primeos merged commit 2932d78 into NixOS:master Jan 25, 2020
@primeos
Copy link
Member

primeos commented Jan 25, 2020

Just to note it here as well: I've opened #78450 in an attempt to find new maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivan @thefloweringash @flokli @primeos