Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeFrameworks: 5.64.0 -> 5.65.0 #77352

Merged
merged 3 commits into from Jan 16, 2020
Merged

kdeFrameworks: 5.64.0 -> 5.65.0 #77352

merged 3 commits into from Jan 16, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 9, 2020

Motivation for this change

https://kde.org/announcements/kde-frameworks-5.65.0.php

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel

@dtzWill dtzWill requested a review from ttuegel as a code owner January 9, 2020 01:54
@FRidh FRidh added this to WIP in Staging via automation Jan 15, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jan 15, 2020
ttuegel
ttuegel approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Staging automation moved this from Needs review to Ready Jan 16, 2020
@ttuegel ttuegel merged commit 6b5edcb into NixOS:staging Jan 16, 2020
Staging automation moved this from Ready to Done Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @ttuegel