Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taskell: 1.7.3 -> 1.9.3 #77315

Merged
merged 3 commits into from Jul 22, 2020
Merged

taskell: 1.7.3 -> 1.9.3 #77315

merged 3 commits into from Jul 22, 2020

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Br1ght0ne
Br1ght0ne approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable works

[3 built, 78 copied (244.0 MiB), 16.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77315
1 package built:
taskell

@dtzWill
Copy link
Member

dtzWill commented Jan 8, 2020

LGTM! Matches what I put together and have been using, too. :)

@dtzWill
Copy link
Member

dtzWill commented Jan 8, 2020

Bummer re:darwin failure (fails to build haskell tz, see builder logs), as taskell previously was building successfully: https://hydra.nixos.org/build/109464110 . Don't know how important this is to Darwin folks but seemed worth mentioning, at least :).

@matthiasbeyer matthiasbeyer changed the title taskell: 1.7.3 -> 1.9.0 taskell: 1.7.3 -> 1.9.2 Feb 6, 2020
@matthiasbeyer matthiasbeyer changed the title taskell: 1.7.3 -> 1.9.2 taskell: 1.7.3 -> 1.9.3 Feb 24, 2020
@matthiasbeyer
Copy link
Contributor Author

How about merging this PR?

@Br1ght0ne
Copy link
Member

@GrahamcOfBorg build taskell

@alyssais
Copy link
Member

Should either be fixed or marked as broken on or incompatible with Darwin and aarch64.

@matthiasbeyer
Copy link
Contributor Author

Should either be fixed or marked as broken on or incompatible with Darwin and aarch64.

How to do that?

@doronbehar
Copy link
Contributor

platforms = [ "x86_64-linux" ];

Br1ght0ne
Br1ght0ne approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[3 built, 266 copied (3297.4 MiB), 222.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77315
1 package built:
taskell

$ nix-shell /home/brightone/.cache/nixpkgs-review/pr-77315/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-77315]$ taskell test
Create /home/brightone/.cache/nixpkgs-review/pr-77315/test? (Y/n):

@matthiasbeyer
taskell: 1.7.3 -> 1.9.0
87d97c6 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
taskell: 1.9.0 -> 1.9.2
dbdd678 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
taskell: 1.9.2 -> 1.9.3
58e83da 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Contributor Author

Please merge this.

1 similar comment
@matthiasbeyer
Copy link
Contributor Author

Please merge this.

@Br1ght0ne Br1ght0ne merged commit 3ed1f3b into NixOS:master Jul 22, 2020
@matthiasbeyer matthiasbeyer deleted the update-taskell branch July 22, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthiasbeyer @dtzWill @Br1ght0ne @alyssais @doronbehar