Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.ppxfind: dontStrip for all versions #77353

Merged
merged 1 commit into from Jan 9, 2020

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Jan 9, 2020

Motivation for this change

I had to add dontStrip to support ppx_deriving (which uses ppxfind) when doing cross compilation to a static musl64 binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl

@marsam
Copy link
Contributor

marsam commented Jan 9, 2020

Thanks!
I've added a missing argument, I hope you don't mind
@GrahamcOfBorg build flow

@anmonteiro
Copy link
Member Author

@marsam not at all! thank you

@marsam marsam merged commit 7fe737d into NixOS:master Jan 9, 2020
@anmonteiro anmonteiro deleted the patch-3 branch January 10, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants