Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Add support for installing Python eggs #77319

Merged
merged 1 commit into from Jan 8, 2020
Merged

python: Add support for installing Python eggs #77319

merged 1 commit into from Jan 8, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 8, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andir

@adisbladis adisbladis requested a review from FRidh January 8, 2020 13:33
@FRidh
Copy link
Member

FRidh commented Jan 8, 2020

woah, egg's, that's prehistoric? Do we really need it? Code looks good, nothing wrong with that, it just feels strange adding support for something that's completely out.

@adisbladis
Copy link
Member Author

adisbladis commented Jan 8, 2020 •
edited

@FRidh I added it for poetry2nix to automatically do the right thing when it encounters an egg. There are legit cases where an egg might be the only option.

Hopefully not something we'd have to use more than occasionally :)

FRidh
FRidh approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough reason.

@FRidh
Copy link
Member

FRidh commented Jan 8, 2020

Ah wait, the manual needs to include these. THere's a list of hooks.

@adisbladis
Copy link
Member Author

I've added docs :)

@adisbladis adisbladis merged commit dd6970c into NixOS:master Jan 8, 2020
@adisbladis adisbladis mentioned this pull request Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @FRidh