Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-play-music-desktop-player: 4.6.1 -> 4.7.1 #77280

Merged
merged 1 commit into from Feb 10, 2020
Merged

google-play-music-desktop-player: 4.6.1 -> 4.7.1 #77280

merged 1 commit into from Feb 10, 2020

Conversation

SuprDewd
Copy link
Contributor

@SuprDewd SuprDewd commented Jan 7, 2020

Motivation for this change

Application seems to be broken at the moment. Fixed by bumping to the version released yesterday.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wedens
Copy link

wedens commented Jan 21, 2020

👍

@FRidh FRidh merged commit c1b3b6f into NixOS:master Feb 10, 2020
@SuprDewd SuprDewd deleted the patch-1 branch February 10, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuprDewd @wedens @FRidh