python3Packages.livelossplot: init at v0.5.0 #77281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcdarwin
changed the title
bcdarwin
force-pushed
the
python-livelossplot
branch
from
bc65637
to
d5ef96e
Compare
doronbehar
reviewed
Feb 23, 2020
bcdarwin
force-pushed
the
python-livelossplot
branch
from
d5ef96e
to
3b58f99
Compare
jonringer
reviewed
Feb 25, 2020
bcdarwin
changed the title
bcdarwin
force-pushed
the
python-livelossplot
branch
from
3b58f99
to
e0e88c0
Compare
jonringer
reviewed
Feb 28, 2020
There was a problem hiding this comment.
can you update commit message to match PR title, still have it at unstable-...
git commit --amend
otherwise LGTM
[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77281
3 package built:
python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot
e0e88c0
to
01c93d3
Compare
|
Commit message rewritten. |
|
@GrahamcOfBorg build python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot |
jonringer
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
diff LGTM
commit LGTM
not sure what is up with "broken" noise
https://github.com/NixOS/nixpkgs/pull/77281
56 package marked as broken and skipped:
digitalbitbox gdata-sharp linuxPackages-libre.sch_cake linuxPackages.sch_cake linuxPackages_4_14.sch_cake linuxPackages_4_4.evdi linuxPackages_5_5.sch_cake linuxPackages_hardened.sch_cake linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.sch_cake linuxPackages_latest-libre.sch_cake linuxPackages_latest_hardened.sch_cake linuxPackages_latest_xen_dom0.sch_cake linuxPackages_latest_xen_dom0_hardened.sch_cake linuxPackages_testing_bcachefs.sch_cake linuxPackages_xen_dom0_hardened.sch_cake muslCross octave-jit php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.pcs php74Packages.php_excel php74Packages.v8 python27Packages.caffe python27Packages.flitBuildHook python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python27Packages.livereload python37Packages.nixpart python37Packages.notify python37Packages.pyblock python38Packages.libselinux python38Packages.nixpart python38Packages.poezio python38Packages.pyblock torchPackages.lua-cjson torchPackages.luaffifb
3 package built:
python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot
7819177
to
054c6cb
Compare
bcdarwin
changed the title
bcdarwin
changed the title
bcdarwin
force-pushed
the
python-livelossplot
branch
from
054c6cb
to
37d3be7
Compare
bcdarwin
force-pushed
the
python-livelossplot
branch
from
37d3be7
to
43d6898
Compare
|
Rebased, updated, and tests fixed. |
|
@GrahamcOfBorg build python27Packages.livelossplot python37Packages.livelossplot python38Packages.livelossplot |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/165 |
|
Result of 2 packages built:- python37Packages.livelossplot - python38Packages.livelossplot |
bhipple
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @