Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] firefox: 71.0 -> 72.0 #77292

Merged
merged 9 commits into from Jan 8, 2020
Merged

[19.09] firefox: 71.0 -> 72.0 #77292

merged 9 commits into from Jan 8, 2020

Conversation

andir
Copy link
Member

@andir andir commented Jan 8, 2020

Motivation for this change

This bumps firefox 71.0 to 72.0. It also removes the patch @fpletz added with 71.0 with the upstream version of that patch that supposedly fixes more issue with e.g. riot.im.

Call for testers: @maralorn @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@andir andir requested a review from fpletz January 8, 2020 00:53
@ofborg ofborg bot requested review from np and edolstra January 8, 2020 01:01
@andir
Copy link
Member Author

andir commented Jan 8, 2020

I am kinda unhappy about the use of dontFixLibtool here... I think it would be better to fixup the cargo hashsum check by putting back the unmodified file.

@taku0
Copy link
Contributor

taku0 commented Jan 8, 2020

Also firefox-esr should be updated (68.3.0esr -> 68.4.0esr).

@maralorn
Copy link
Member

maralorn commented Jan 8, 2020

I have compiled this (e.g. firefox 72) successfully and tried it out it bit. I don‘t see any problems. riot.im works.

This was referenced Jan 8, 2020
Closed
Closed
@andir
Copy link
Member Author

andir commented Jan 8, 2020

Added the -esr-68 update as well build is still running against this branch.

@andir andir merged commit db5273c into NixOS:release-19.09 Jan 8, 2020
@andir andir deleted the 19.09-firefox72 branch January 8, 2020 19:24
This was referenced Jan 8, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@np np Awaiting requested review from np

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @taku0 @maralorn