Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krop: Add wrapQtAppsHook. #77356

Merged
merged 1 commit into from Jan 16, 2020
Merged

krop: Add wrapQtAppsHook. #77356

merged 1 commit into from Jan 16, 2020

Conversation

moretea
Copy link
Contributor

@moretea moretea commented Jan 9, 2020

Motivation for this change

krop segfaults, because it was missing the QT plugin wrapper. Closes #77339

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @leenaars

@moretea moretea changed the title krop: Add wrapQtAppsHook. Closes #77339 krop: Add wrapQtAppsHook. Jan 9, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 9, 2020

cc @ttuegel for #65399

@moretea
Copy link
Contributor Author

moretea commented Jan 9, 2020

The change is based on this PR & changed line for anki: 39028ee#diff-427d03e6e9235a5908b7370d6afb0917R164

@ttuegel ttuegel merged commit 32907db into NixOS:master Jan 16, 2020
@moretea
Copy link
Contributor Author

moretea commented Jan 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

krop segfaults
3 participants