-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Port elk initdb kafka #77303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port elk initdb kafka #77303
Conversation
@GrahamcOfBorg test initdb elk kafka |
|
Do you mean including in the sense of grouping it into another existing postgres test file or giving it a similar name like the others? |
Whatever you feel to be more appropriate. Personally, I'd say it's small enough to just group it into an existing test. |
Oh, you mean actually putting the code into the test script of an existing test. That makes sense, too. I am on it. |
@flokli done, please have a look. |
@GrahamcOfBorg test postgres |
@GrahamcOfBorg test postgresql |
Motivation for this change
#72828
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @worldofpeace @flokli