Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heroku: 7.33.1 -> 7.35.1 #77302

Merged
merged 1 commit into from Jan 8, 2020
Merged

heroku: 7.33.1 -> 7.35.1 #77302

merged 1 commit into from Jan 8, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from aflatter and peterhoeg January 8, 2020 10:11
Br1ght0ne
Br1ght0ne approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable shows help text

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77302
1 package built:
heroku

@marsam marsam merged commit 223c8b6 into NixOS:master Jan 8, 2020
@marsam marsam deleted the update-heroku branch January 8, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@aflatter aflatter Awaiting requested review from aflatter

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @Br1ght0ne