Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conmon: v2.0.8 -> v2.0.9 #77221

Merged
merged 1 commit into from Jan 8, 2020
Merged

conmon: v2.0.8 -> v2.0.9 #77221

merged 1 commit into from Jan 8, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 7, 2020 •
edited

Motivation for this change

Update conmon to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vdemeester

@saschagrunert
conmon: v2.0.8 -> v2.0.9
d4a9b0a 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@ofborg ofborg bot requested a review from vdemeester January 7, 2020 12:50
vdemeester
vdemeester approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@marsam marsam merged commit 0a4c110 into NixOS:master Jan 8, 2020
@marsam
Copy link
Contributor

marsam commented Jan 8, 2020

Thanks!

@saschagrunert saschagrunert deleted the conmon branch January 8, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschagrunert @marsam @vdemeester