Add test automation for manual native file system tests. #21096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 8, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1989369
branch
2 times, most recently
from
4d4efad
to
4596fc7
Compare
This adds two new methods to testRunner: - getWritableDirectory, which returns the path to an an (empty, per test) temporary directory. And - setFilePathForMockFileDialog, which causes all file dialogs that are shown by the test to return the provided file path. This is then used to automate the otherwise manual native file system web platform tests that try to interact with the actual native native file system implementation (as opposed to the sandboxed file system). Also rename the filenames of these manual tests so the test system actually correctly picks them up. Unfortunately not all of the tests are currently passing, so this also checks in test expectations for the failing tests. Bug: 998917 Change-Id: I0c9100d39387bb211c3108c7566937af0e75db68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989369 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732156}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1989369
branch
from
4596fc7
to
778f637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new methods to testRunner:
(empty, per test) temporary directory. And
are shown by the test to return the provided file path.
This is then used to automate the otherwise manual native file system
web platform tests that try to interact with the actual native native
file system implementation (as opposed to the sandboxed file system).
Also rename the filenames of these manual tests so the test system
actually correctly picks them up. Unfortunately not all of the tests
are currently passing, so this also checks in test expectations for
the failing tests.
Bug: 998917
Change-Id: I0c9100d39387bb211c3108c7566937af0e75db68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989369
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732156}