Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.crc32c: init at 2.0 #77283

Merged
merged 1 commit into from Jan 8, 2020
Merged

pythonPackages.crc32c: init at 2.0 #77283

merged 1 commit into from Jan 8, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 7, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • [NA] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [NA] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Jan 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message should still point to an installable:

version of python doesn't matter unless that version is unsupported.

pythonPackages.crc32c: init at 2.0

I can't remember the reason, but generally aligning the equal signs is not preferred. I think it was for automated scripts which may not preserve white-space. But can't remmber exactly

I guess 2-3 nits, otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/77283
3 package were built:
python27Packages.crc32c python37Packages.crc32c python38Packages.crc32c

pkgs/development/python-modules/crc32c/default.nix Outdated Show resolved Hide resolved
@bcdarwin bcdarwin force-pushed the python-crc32c branch 3 times, most recently from bcf90df to d39d14d Compare January 7, 2020 23:26
@bcdarwin
Copy link
Member Author

bcdarwin commented Jan 7, 2020

Everything resolved.

@bcdarwin bcdarwin changed the title python{2,3}Packages.crc32c: init at 2.0 pythonPackages.crc32c: init at 2.0 Jan 7, 2020
jonringer
jonringer approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/77283
3 package were built:
python27Packages.crc32c python37Packages.crc32c python38Packages.crc32c

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.crc32c python37Packages.crc32c python38Packages.crc32c

@jonringer jonringer merged commit 81179a4 into NixOS:master Jan 8, 2020
@bcdarwin bcdarwin deleted the python-crc32c branch January 11, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @jonringer