Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] firefox: 72.0 -> 72.0.1 #77349

Merged
merged 3 commits into from Jan 9, 2020
Merged

[19.09] firefox: 72.0 -> 72.0.1 #77349

merged 3 commits into from Jan 9, 2020

Conversation

andir
Copy link
Member

@andir andir commented Jan 8, 2020

Motivation for this change

Mozilla released yet another version of Firefox. This fixes the build on aarch64 while bumping the version. The 72.0 release we merged earlier today didn't compile on aarch64 (on at least 19.09).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @ivan

@andir
firefox: 72.0 -> 72.0.1
71b2829 
(cherry picked from commit aab1f2d)
@andir
firefox-esr-68: 68.4.0esr -> 68.4.1esr
1cedf06 
(cherry picked from commit 204d32a)
@andir
firefox: fix build of >=72 on aarch64
8141b69 
(cherry picked from commit b4983fe)
@ofborg ofborg bot requested a review from edolstra January 8, 2020 23:48
@KamilaBorowska
Copy link
Member

CVE-2019-17026 is being exploited in the wild. This should be merged ASAP.

@edolstra edolstra merged commit 9175907 into NixOS:release-19.09 Jan 9, 2020
@jakobrs jakobrs mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @KamilaBorowska @edolstra