Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reattach-to-user-namespace: 2.7 -> 2.8 #77306

Merged
merged 1 commit into from Jan 8, 2020
Merged

reattach-to-user-namespace: 2.7 -> 2.8 #77306

merged 1 commit into from Jan 8, 2020

Conversation

gpevnev
Copy link
Contributor

@gpevnev gpevnev commented Jan 8, 2020 •
edited

Add macOS Catalina (10.15) "support".

Motivation for this change

On Catalina 10.15.2 previous version raised warning:
warning: /nix/store/qn9gd6zk196nicm3j7mkbi23n6cfr47v-reattach-to-user-namespace-2.7/bin/reattach-to-user-namespace: unsupported new OS, trying as if it were 10.10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @LnL7

@gpevnev
reattach-to-user-namespace: 2.7 -> 2.8
a17dbd8 
Add macOS Catalina (10.15) "support".
LnL7
LnL7 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FYI reattach-to-user-namespace hasn't been needed when using tmux, etc. for a few macOS releases now so I'm not sure how useful this actually still is.

@LnL7 LnL7 merged commit e0b00ed into NixOS:master Jan 8, 2020
@ofborg ofborg bot requested a review from LnL7 January 8, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gpevnev @LnL7 @Janik-Haag