Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-sdk: include openssl(1) in PATH #77277

Merged
merged 1 commit into from Jan 10, 2020
Merged

google-cloud-sdk: include openssl(1) in PATH #77277

merged 1 commit into from Jan 10, 2020

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Jan 7, 2020

Motivation for this change

Otherwise, it might fail with a mysterious error:

ERROR: (gcloud.beta.compute.reset-windows-password) Your platform does not support OpenSSL.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edef1c
google-cloud-sdk: include openssl(1) in PATH
970d5f4 
Otherwise, it might fail with a mysterious error:

    ERROR: (gcloud.beta.compute.reset-windows-password) Your platform does not support OpenSSL.
@ofborg ofborg bot requested review from zimbatm and pradyuman January 9, 2020 18:12
@zimbatm zimbatm merged commit 178ac3c into NixOS:master Jan 10, 2020
@edef1c edef1c deleted the gcloud-openssl branch January 15, 2020 19:50
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 21, 2020
@edef1c @dtzWill
google-cloud-sdk: include openssl(1) in PATH (NixOS#77277)
1ec6244 
Otherwise, it might fail with a mysterious error:

    ERROR: (gcloud.beta.compute.reset-windows-password) Your platform does not support OpenSSL.

(cherry picked from commit 178ac3c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@pradyuman pradyuman Awaiting requested review from pradyuman

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edef1c @zimbatm