Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mrsh: init at 2020-01-08 #77307

Merged
merged 1 commit into from
Jan 9, 2020
Merged

mrsh: init at 2020-01-08 #77307

merged 1 commit into from
Jan 9, 2020
+26 −0

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 8, 2020
Br1ght0ne
Br1ght0ne reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few stylistic nitpicks, other than that - LGTM

[3 built, 1 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77307
1 package built:
mrsh

pkgs/shells/mrsh/default.nix Outdated
src = fetchFromGitHub {
owner = "emersion";
repo = "mrsh";
rev = version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and specifying the commit hash only in fetchFromGitHub.

Suggested change
rev = version;
rev = "ef21854fc9ce172fb1f7f580b19a89d030d67c65";

@doronbehar
Copy link
Contributor

Also the title of the PR should match the one of the commit.

@matthiasbeyer matthiasbeyer changed the title Add mrsh mrsh: init at 2020-01-08 Jan 8, 2020
Br1ght0ne
Br1ght0ne approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthiasbeyer
Copy link
Contributor Author

@GrahamcOfBorg build mrsh

@matthiasbeyer
mrsh: init at 2020-01-08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
dd78f9c 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@markuskowa markuskowa merged commit 4f7f962 into NixOS:master Jan 9, 2020
@matthiasbeyer matthiasbeyer deleted the add-mrsh branch January 9, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthiasbeyer @doronbehar @Br1ght0ne @markuskowa